Differential D23370

Don't install a scheme handler for the "about" protocol
ClosedPublic
Actions

Authored by stefanocrocco on Aug 23 2019, 8:00 AM.

Details

Reviewers
dfaure
Commits
R226:4693187a1f9a: Don't install a scheme handler for the "about" protocol
Summary

The default mimetype for the "about" protocol is "text/html", so
WebEnginePart::attemptInstallKIOSchemeHandler will try to install a
scheme handler for it. This will fail with a warning from Qt because
"about" is an internal protocol.

Test Plan

configure Konqueror so that it displays the introduction page at
startup, launch it from terminal and check that no warnings regarding the
"about" protocol are displayed.

Diff Detail

Repository
R226 Konqueror
Branch
fix-warning-scheme-handler-about
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15520
Build 15538: arc lint + arc unit
stefanocrocco requested review of this revision.Aug 23 2019, 8:00 AM
stefanocrocco created this revision.
dfaure accepted this revision.Aug 24 2019, 8:31 AM
This revision is now accepted and ready to land.Aug 24 2019, 8:31 AM
Closed by commit R226:4693187a1f9a: Don't install a scheme handler for the "about" protocol (authored by stefanocrocco). · Explain WhyAug 24 2019, 8:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 64394

View Options

webenginepart/src/webenginepart.cpp

Loading...