improve code in Snore backend
AbandonedPublic

Authored by brute4s99 on Wed, Aug 21, 12:57 AM.

Details

Reviewers
broulik

Diff Detail

Repository
R289 KNotifications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15389
Build 15407: arc lint + arc unit
brute4s99 created this revision.Wed, Aug 21, 12:57 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptWed, Aug 21, 12:57 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
brute4s99 requested review of this revision.Wed, Aug 21, 12:57 AM

I don't really see the point in this cleanup as it only messes up git history and doesn't actually follow coding style better

src/notifybysnore.cpp
141

The previous coding style was correct, asterisk goes with the name, not the type.

162

Plus goes on a new line so you can see without horizontally scroling what operator is being used:

foo = bar
    + baz
brute4s99 abandoned this revision.Thu, Aug 22, 2:44 AM

in that case I should rather leave this diff. I agree this would be messy for the history.