Unify busy spinner appearance on update page
AbandonedPublic

Authored by ngraham on Aug 20 2019, 5:26 PM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
Summary

The busy spinner on the main page is in the center of the view and it's not humongous.
Let's do the same thing on the updates page. As part of this, we can get rid of the
"Fetching updates..." text, because it's already perfectly clear what's going on.

Test Plan

Diff Detail

Repository
R134 Discover Software Store
Branch
unify-busy-spinners (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15360
Build 15378: arc lint + arc unit
ngraham created this revision.Aug 20 2019, 5:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 20 2019, 5:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 20 2019, 5:26 PM
ngraham edited the summary of this revision. (Show Details)Aug 20 2019, 5:27 PM
apol added a comment.Aug 20 2019, 5:38 PM

We don't want any text?

All it used to say was "Fetching updates..." which I think is adequately implied by it being a busy spinner on the Updates page. The spinner on the main page doesn't say, "Fetching applications" or whatever, so I was trying to be consistent with that. Your call though.

apol added a comment.Aug 20 2019, 6:27 PM

As is, it looks unfinished to me. I prefer to give some kind of hint of what's happening, especially since this could take a while, yesterday I opened one laptop after a month (neon git unstable) or so and it took easily a minute to show anything there.
In fact, we could look into showing progress here, which is what I wanted looking at the thing spin to no end.

If there's a way to show an actual progress indicator in a way that ensures its accuracy, that would be much better, yeah. I'll be happy to abandon this patch if you can do that (I don't know how, sorry).

ngraham abandoned this revision.Thu, Aug 22, 10:22 PM

Abandoning in favor of the vastly superior D23357.