Move XResources out of the central model into a plugin
Needs ReviewPublic

Authored by davidedmundson on Tue, Aug 20, 10:50 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

XRes works in an odd way, the evaluation is inside the processui model,
then it gets sent back into the process and proxied round.

It leaves code in ProcessCore that doesn't work in a way one would expect.
Though for API compat it can't be completely tidied up yet.

By moving to a plugin we get no more ifdefs, no more special casing
inside the core model.

XRes extraction code is unchanged only moved

Diff Detail

Repository
R111 KSysguard Library
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15372
Build 15390: arc lint + arc unit
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Aug 20, 10:50 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Tue, Aug 20, 10:50 AM
apol added a subscriber: apol.Tue, Aug 20, 3:46 PM
apol added inline comments.
processplugins/xres/xres.cpp
2

What's the copyright?

7

Scope shouldn't be necessary

processplugins/xres/xres.h
2

Copyright?

First time I see #pragma once in KDE software.

processui/ProcessModel.h
157

if you pass 3/// you can just as well use ///<@deprecated. in xres plugin now

davidedmundson marked 4 inline comments as done.Tue, Aug 20, 4:20 PM
davidedmundson added inline comments.
processplugins/xres/xres.h
2

I've used #pragma once all over the place already, hasn't seemed to cause an issue.

davidedmundson marked an inline comment as done.

update

mart added a subscriber: mart.Tue, Aug 27, 8:45 AM
mart added inline comments.
processplugins/xres/xres.h
2

I use it quite a lot as well.
If it has problems better to know it before it spreads too much ;)

is not standard but appears to be supported fine on any modern compiler