Differential D23144

Port from QFontMetrics::width() to boundingRect().width()
ClosedPublic
Actions

Authored by gladhorn on Aug 14 2019, 7:49 AM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:6a064319629d: Port from QFontMetrics::width() to boundingRect().width()
Summary

In all the cases that were changed, the bounding rect is needed. A few
places were not ported, since they need more careful investigation.
This reduces deprecation warnings.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn created this revision.Aug 14 2019, 7:49 AM
Restricted Application added a project: Konsole. · View Herald TranscriptAug 14 2019, 7:49 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
gladhorn requested review of this revision.Aug 14 2019, 7:49 AM
hindenburg added a subscriber: hindenburg.Aug 16 2019, 4:20 PM
In D23144#511617, @gladhorn wrote:

See also https://kdepepo.wordpress.com/2019/08/05/about-deprecation-of-qfontmetricswidth/

yea, for reference also in https://doc.qt.io/qt-5/qfontmetrics-obsolete.html there are notes:
"Note that this value is not equal to boundingRect().width(); boundingRect() returns a rectangle describing the pixels this string will cover whereas width() returns the distance to where the next string should be drawn."

gladhorn added a comment.Aug 16 2019, 5:42 PM

Yes, so for size hints, this should be fine. For actually placing individual chars and calculating their width in the terminal window I didn't dare changing things.

hindenburg accepted this revision.Aug 17 2019, 2:23 PM

I agree thanks

This revision is now accepted and ready to land.Aug 17 2019, 2:23 PM
Closed by commit R319:6a064319629d: Port from QFontMetrics::width() to boundingRect().width() (authored by gladhorn, committed by hindenburg). · Explain WhyAug 17 2019, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 63924