In all the cases that were changed, the bounding rect is needed. A few
places were not ported, since they need more careful investigation.
This reduces deprecation warnings.
Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:6a064319629d: Port from QFontMetrics::width() to boundingRect().width()
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
yea, for reference also in https://doc.qt.io/qt-5/qfontmetrics-obsolete.html there are notes:
"Note that this value is not equal to boundingRect().width(); boundingRect() returns a rectangle describing the pixels this string will cover whereas width() returns the distance to where the next string should be drawn."
Comment Actions
Yes, so for size hints, this should be fine. For actually placing individual chars and calculating their width in the terminal window I didn't dare changing things.