Enable enhanced media controls by default
ClosedPublic

Authored by broulik on Tue, Aug 13, 7:34 AM.

Details

Summary

Media Sessions API usage becomes more and more common, so it is quite nice to get proper album art. Also, calling into media session for play/pause when the website provides them is nicer than blatantly calling pause() on the player item.
It also isn't as invasive as the original implementation used to be since it doesn't manipulate the website DOM anymore.

Test Plan

I've been using this forever without any hickups.
I also couldn't reproduce the Bug 397684 at all and likely to have been caused by the HTML element we injected into the website throwing off some JS templating lib.

David I think said once that he could reproduce it or is running home assist, so can you check if it works for you still?

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Tue, Aug 13, 7:34 AM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Aug 13, 7:34 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Tue, Aug 13, 7:34 AM
fvogt accepted this revision.Tue, Aug 13, 7:58 AM
This revision is now accepted and ready to land.Tue, Aug 13, 7:58 AM
This revision was automatically updated to reflect the committed changes.