fix streamsocket write-length calculation
ClosedPublic

Authored by sitter on Mon, Aug 12, 12:11 PM.

Details

Summary

TrafficShapedSocket::write has a somewhat narrow contract with its caller.
max may be 0 or >0, 0 meaning no limit, >0 meaning limit.
this was incorrectly implemented before where we'd assume max means always
limit, resulting in unlimited calls always resulting in 0 data getting
sent as max would be 0.

the revised code explicitly handles 0 meaning no limit. this is in line
with the behavior of PacketSocket, the only other implementation of
a shaped socket.

BUG: 382375

Test Plan

webseeds start working by default and download at full bandwith

Diff Detail

Repository
R472 KTorrent Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter requested review of this revision.Mon, Aug 12, 12:11 PM
sitter created this revision.
stikonas accepted this revision.Mon, Aug 12, 7:01 PM
This revision is now accepted and ready to land.Mon, Aug 12, 7:01 PM
This revision was automatically updated to reflect the committed changes.