visibleActions is really only used to check whether there are
any actions visible at all, the number is irrelevant. For some
unknown reason the old logic would occasionally get caught in
some out of order silliness (so we'd end up with a negative
number of visible actions), but with this logic we only check
whether there is any visible actions at all, so the whole thing
is less stateful.
Details
Details
- Reviewers
mart - Group Reviewers
Kirigami - Commits
- R169:56d3ccd95753: Rework the visibleActions logic in SwipeListItem
Using Peruse on mobile, load up the Store and see that with the
old logic there are no handles on the items. With the new
logic there is.
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Branch
- rework-swipelistitem-visible-actions-logic (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15047 Build 15065: arc lint + arc unit