Differential D2310

[Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down
ClosedPublic
Actions

Authored by net147 on Jul 30 2016, 3:56 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R119:ae319ac4fbe6: [Kickoff] Fix being unable to reorder entries in favorites menu after…
Summary

BUG: 345741

Test Plan

I have many entries in the favorites menu. I can reorder the entries if the vertical scrollbar is at the top but if I scroll to the bottom of the favorites menu and try to reorder the items, it doesn't show a drop indicator for anywhere other than the end of the favorites list.

Steps to Reproduce:

  1. Add lots of applications to favorites such that less than half of the favorites are shown when you scroll to the top of the favorites menu list
  2. Scroll to the bottom of the favorites list
  3. Click and drag the 3rd-last item up one position

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
net147 updated this revision to Diff 5566.Jul 30 2016, 3:56 AM
net147 retitled this revision from to [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down.
net147 updated this object.
net147 edited the test plan for this revision. (Show Details)
net147 added a reviewer: Plasma.
net147 set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 30 2016, 3:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
net147 updated this object.Jul 30 2016, 6:27 AM
net147 edited the test plan for this revision. (Show Details)
broulik added a subscriber: broulik.Jul 30 2016, 8:52 AM

Thanks for your patch!

Can you make sure you're working on the recent-most plasma-desktop master branch? I've recently changed the favorites sorting to reorder the items live as you drag them (like task manager or kicker do it).

net147 added a comment.Jul 30 2016, 8:55 AM
In D2310#43102, @broulik wrote:

Thanks for your patch!

Can you make sure you're working on the recent-most plasma-desktop master branch? I've recently changed the favorites sorting to reorder the items live as you drag them (like task manager or kicker do it).

Yes, the patch is based on the latest revision of the plasma-desktop master branch.

broulik accepted this revision.Jul 30 2016, 9:08 AM
broulik added a reviewer: broulik.

Thanks. This fixes the issue for me. Do you have commit access?

This revision is now accepted and ready to land.Jul 30 2016, 9:08 AM
net147 added a comment.EditedJul 30 2016, 9:45 AM
In D2310#43105, @broulik wrote:

Thanks. This fixes the issue for me. Do you have commit access?

I don't have commit access. Please commit this for me and then mark the bug as fixed.

net147 updated this revision to Diff 5592.Aug 1 2016, 2:10 AM
net147 edited edge metadata.

Added copyright.

Closed by commit R119:ae319ac4fbe6: [Kickoff] Fix being unable to reorder entries in favorites menu after… (authored by net147, committed by bshah). · Explain WhyAug 2 2016, 7:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 5623

View Options

applets/kickoff/package/contents/ui/FavoritesView.qml

Loading...