[Task Manager] Add icon to the grouping menu entry
ClosedPublic

Authored by simonkr on Aug 11 2019, 2:56 PM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
simonkr created this revision.Aug 11 2019, 2:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptAug 11 2019, 2:56 PM
simonkr requested review of this revision.Aug 11 2019, 2:56 PM
GB_2 added a subscriber: GB_2.Aug 11 2019, 5:55 PM

I think the icon view-group fits better.

applets/taskmanager/package/contents/ui/ContextMenu.qml
577

Add an empty line after this.

simonkr updated this revision to Diff 63568.EditedAug 11 2019, 7:12 PM

Update icon to view-group

simonkr edited the summary of this revision. (Show Details)Aug 11 2019, 7:13 PM
GB_2 retitled this revision from Add icon to the taskmanager grouping menu entry to [Task Manager] Add icon to the grouping menu entry.Aug 11 2019, 7:57 PM
GB_2 added a reviewer: hein.
GB_2 set the repository for this revision to R119 Plasma Desktop.

Don't forget the inline comment ;-)

simonkr updated this revision to Diff 63578.Aug 11 2019, 8:51 PM

Add a Space

simonkr marked an inline comment as done.Aug 11 2019, 8:51 PM
simonkr updated this revision to Diff 63580.Aug 11 2019, 9:00 PM
GB_2 updated this revision to Diff 63584.Aug 11 2019, 9:10 PM

Fix indentation

GB_2 updated this revision to Diff 63585.Aug 11 2019, 9:11 PM

Fix diff

GB_2 accepted this revision as: VDG, GB_2.Aug 11 2019, 9:11 PM
This revision is now accepted and ready to land.Aug 11 2019, 9:11 PM
ngraham accepted this revision.Aug 11 2019, 9:11 PM
ngraham added a subscriber: ngraham.

LGTM!

This revision was automatically updated to reflect the committed changes.