Make it possible to provide a page header to ScrollablePage
AbandonedPublic

Authored by apol on Jul 28 2016, 6:50 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Summary

Sometimes we show some information on top of a flickable that goes away as
soon as the user scrolls down.
This introduces a property that offers a component to be shown when the view
is scrolled, optionally of course.

Test Plan

Extends the ListView example. Been tested locally on Discover.

Diff Detail

Repository
R169 Kirigami
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol updated this revision to Diff 5546.Jul 28 2016, 6:50 PM
apol retitled this revision from to Make it possible to provide a page header to ScrollablePage.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami. · View Herald TranscriptJul 28 2016, 6:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol updated this revision to Diff 5547.Jul 28 2016, 10:43 PM

Add api documentation

apol updated this revision to Diff 5549.Jul 28 2016, 11:07 PM

Fix naming

mart edited edge metadata.Jul 29 2016, 8:34 AM

seems to behave a bit strangely, especially its interaction with the global ApplicationHeader is quite strange

apol added a comment.Jul 29 2016, 9:54 AM
In D2306#42989, @mart wrote:

seems to behave a bit strangely, especially its interaction with the global ApplicationHeader is quite strange

What is that you don't like exactly? I can look into it if you tell me.

mart added a comment.Jul 29 2016, 1:03 PM
In D2306#43005, @apol wrote:
In D2306#42989, @mart wrote:

seems to behave a bit strangely, especially its interaction with the global ApplicationHeader is quite strange

What is that you don't like exactly? I can look into it if you tell me.

it should just be a fixed header, always visible and laid out with the main content or flickable, it should be in Page (and just happening to work in scrollablepage too) and the property called just header, not pageHeader

ie it has to be as much identical as possible to
http://doc.qt.io/qt-5/qml-qtquick-controls2-page.html

because Page is going to inherit from that one in the future

apol added a comment.Jul 29 2016, 2:14 PM
In D2306#43024, @mart wrote:

it should just be a fixed header, always visible and laid out with the main content or flickable, it should be in Page (and just happening to work in scrollablepage too) and the property called just header, not pageHeader

ie it has to be as much identical as possible to
http://doc.qt.io/qt-5/qml-qtquick-controls2-page.html

because Page is going to inherit from that one in the future

I'm not sure that's what I need. Should I implement it in Discover and when we move to Qt 5.7 we see what should be upstreamed, if anything?

apol abandoned this revision.Aug 24 2016, 1:49 AM

Too specific to Discover.