[Image Wallpaper] Use layer.enabled during transition to avoid background glimpsing through

Authored by broulik on Aug 8 2019, 6:52 AM.


Group Reviewers

Opacity affects each item individually, so during the transition, you have an Image with a certain opacity and a Rectangle behind it. Since the Image has its opacity transition to zero, you can see through it to the background Rectangle behind it.
Using layer during the transition we can combine the entire item into a single surface and animate its opacity as a whole.

BUG: 410313
FIXED-IN: 5.17.0

Test Plan
  • Wallpaper transition doesn't flash anymore. Previously was most noticeable when just changing the size mode (e.g. from stretched to centered)

Not really sure about the performance implications of using layer on such a a large surface?

Diff Detail

R120 Plasma Workspace
Lint Skipped
Unit Tests Skipped
broulik created this revision.Aug 8 2019, 6:52 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 8 2019, 6:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Aug 8 2019, 6:52 AM
ngraham accepted this revision.Aug 8 2019, 6:51 PM
ngraham added a subscriber: ngraham.

Can confirm that it fixes the bug and looks nicer.

This revision is now accepted and ready to land.Aug 8 2019, 6:51 PM
broulik planned changes to this revision.Dec 9 2019, 5:31 PM

I think we need to measure the performance impact somewhat

@ahiemstra any ideas here? Maybe you can work your shader magic if this isn't performant enough? :)

broulik abandoned this revision.Thu, May 21, 9:19 AM

Yeah, would love some @ahiemstra shader magic there :)