Differential D23009

LSP plugin: Use language id instead of highlighting mode for server identification
ClosedPublic
Actions

Authored by cullmann on Aug 7 2019, 7:45 PM.

Details

Reviewers
mnauwelaerts
dhaumann
Commits
R40:09427e8cde87: LSP plugin: Use language id instead of highlighting mode for server…
Summary

Use the standardized language id in more places.

Why?

  • the LSP names are "standardized"
  • we can internally map different C++/... highlightings to the same canonical LSP lanuage id name

Diff Detail

Repository
R40 Kate
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14850
Build 14868: arc lint + arc unit
cullmann created this revision.Aug 7 2019, 7:45 PM
Restricted Application added a project: Kate. · View Herald TranscriptAug 7 2019, 7:45 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
cullmann requested review of this revision.Aug 7 2019, 7:45 PM
cullmann added a comment.Aug 7 2019, 8:12 PM

;=) I guess I missed to add any argument why we should do this

  1. the LSP names are "standardized"
  2. we can internally map different C++/... highlightings to the same canonical LSP lanuage id name
dhaumann accepted this revision.Aug 7 2019, 8:18 PM
dhaumann edited the summary of this revision. (Show Details)
dhaumann retitled this revision from use language id instead of highlighting mode for server identification to LSP plugin: Use language id instead of highlighting mode for server identification.
dhaumann added a subscriber: dhaumann.

That makes a lot of sense and is likely more robust for now.

This revision is now accepted and ready to land.Aug 7 2019, 8:20 PM
cullmann added a comment.Aug 7 2019, 8:22 PM

Let's wait what Mark says, it's anyways sleep time .P

mnauwelaerts accepted this revision.Aug 7 2019, 9:53 PM
Closed by commit R40:09427e8cde87: LSP plugin: Use language id instead of highlighting mode for server… (authored by cullmann). · Explain WhyAug 8 2019, 6:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 63313

View Options

addons/lspclient/lspclientservermanager.cpp

Loading...