categorized logging for kscreen kcm
ClosedPublic

Authored by sebas on Jul 27 2016, 1:43 AM.

Details

Summary
  • add category kscreen.kcm
  • switch all debug statements in kcm to categorized logging
Test Plan

tested manually, works as expected

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sebas updated this revision to Diff 5512.Jul 27 2016, 1:43 AM
sebas retitled this revision from to categorized logging for kscreen kcm.
sebas updated this object.
sebas edited the test plan for this revision. (Show Details)
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 27 2016, 1:43 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added inline comments.
kcm/src/debug.h
26

There's a CMake macro for all this file.

sebas added inline comments.Jul 28 2016, 10:27 AM
kcm/src/debug.h
26

That's how it's done for the other components in this repo as well, so I went for that same solution here as well.

bshah accepted this revision.Jul 28 2016, 10:44 AM
bshah added a reviewer: bshah.
bshah added a subscriber: bshah.

Apart from d_ed's comment looks good, perhaps you can change to ecm macro in different revision...

This revision is now accepted and ready to land.Jul 28 2016, 10:44 AM
This revision was automatically updated to reflect the committed changes.