Differential D22923

[Night Color KCM] Rename "Manual" mode to "Constant"
ClosedPublic
Actions

Authored by zzag on Aug 4 2019, 12:44 PM.

Details

Reviewers
GB_2
ngraham
Group Reviewers
Plasma
VDG
Commits
R119:68c51ae798da: [Night Color KCM] Rename "Manual" mode to "Constant"
Summary

Both the Night Color (KDE Plasma) and the Night Light (GNOME Shell) have
so called "Manual" mode. In each case, this mode denotes something
different.

If the Night Color operates in the Manual mode, then the color temperature
remains constant throughout the day. On other hand, the Manual mode in the
Night Light is similar to the Timings mode in the Night Color.

This change renames the Manual mode in order to alleviate the mismatch in
terminology.

Test Plan


Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Aug 4 2019, 12:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 4 2019, 12:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Aug 4 2019, 12:44 PM
GB_2 accepted this revision as: VDG, GB_2.Aug 4 2019, 12:51 PM
This revision is now accepted and ready to land.Aug 4 2019, 12:51 PM
zzag edited the test plan for this revision. (Show Details)Aug 4 2019, 12:51 PM
ngraham accepted this revision.Aug 4 2019, 2:29 PM
zzag added a comment.Aug 4 2019, 2:47 PM

I'll land this patch in 24h if there are no objections from Plasma.

Closed by commit R119:68c51ae798da: [Night Color KCM] Rename "Manual" mode to "Constant" (authored by zzag). · Explain WhyAug 6 2019, 10:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 63165

View Options

kcms/nightcolor/package/contents/ui/main.qml

Loading...