Details

Reviewers

Group Reviewers

VDG
Plasma

Summary

All of the colors pulled from a colorscheme in Breeze GTK now use GTK's color definitons, allowing them to be changed without recompiling the theme.
GTK18 and GTK20 have been merged as well, lessening work required to make changes & maintain.
There are some other minor changes (radio buttons/checkboxes now sink in when clicking as their Qt counterparts do.)
The varaible $new-highlight has been added to gtk.scss. Toggling it to true will cause the highlights to resemble ndavis/highlight @ Breeze. Added that because I had already made the changes to the theme when I did the colordefs, and I don't want to wait on the new highlight style to be set in stone before this can be merged.

One caveat - checkboxes and radiobuttons are hardcoded at build time because they're PNGs. However, the design trend in GNOME applications is to move away from checkboxes and radiobuttons, and they're relatively minor in the grand scheme of things. Redoing them somehow is most likely out of the scope of this revision.

Test Plan

See that the theme works as intended with GTK color definitions.

Diff Detail

Repository

R98 Breeze for Gtk

Branch

colordefs (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14628
Build 14646: arc lint + arc unit

cblack created this revision.Jul 31 2019, 12:32 AM

Restricted Application added a project: Plasma. · View Herald TranscriptJul 31 2019, 12:32 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

cblack requested review of this revision.Jul 31 2019, 12:32 AM

Harbormaster completed remote builds in B14592: Diff 62822.Jul 31 2019, 12:32 AM

cblack mentioned this in D22844: [kcm-colors] Export colorscheme to GTK color definitions.Jul 31 2019, 12:33 AM

Forgot about changing the build_theme.sh to export to my home directory under the name Breeze-Dev, reversed that

Harbormaster completed remote builds in B14594: Diff 62824.Jul 31 2019, 12:36 AM

Good job at picking up that change, arc. See previous change.

Harbormaster completed remote builds in B14595: Diff 62825.Jul 31 2019, 12:37 AM

Fix some issues with incorrect colors being used

Harbormaster completed remote builds in B14615: Diff 62858.Jul 31 2019, 2:46 PM

Neato mosquito!

Unfortunately, it doesn't build:

[ 75%] Building CXX object kconf_update/CMakeFiles/gtkbreeze5.5.dir/main.cpp.o
Installing into /home/nate/kde/build/breeze-gtk/Breeze-Dark
[ 75%] Built target Breeze-Dark
Installing into /home/nate/kde/build/breeze-gtk/Breeze
cp: cannot stat 'gtk-dark-3.18.css': No such file or directory

Looks like your change in build_theme.sh had some unintended consequences. I guess we still need the 3.18 dirs for compatibility, or else we need to formally deprecate 3.18 and remove all traces of it.

This revision now requires changes to proceed.Aug 1 2019, 12:23 AM

Fix CMakeLists.txt

Harbormaster completed remote builds in B14627: Diff 62881.Aug 1 2019, 1:06 AM

Forgot to add you

Harbormaster completed remote builds in B14628: Diff 62882.Aug 1 2019, 1:07 AM

In D22845#504927, @ngraham wrote:
Neato mosquito!

Unfortunately, it doesn't build:
[ 75%] Building CXX object kconf_update/CMakeFiles/gtkbreeze5.5.dir/main.cpp.o
Installing into /home/nate/kde/build/breeze-gtk/Breeze-Dark
[ 75%] Built target Breeze-Dark
Installing into /home/nate/kde/build/breeze-gtk/Breeze
cp: cannot stat 'gtk-dark-3.18.css': No such file or directory
Looks like your change in build_theme.sh had some unintended consequences. I guess we still need the 3.18 dirs for compatibility, or else we need to formally deprecate 3.18 and remove all traces of it.

Just changed the CMakeLists.txt and readded a needed file, it should build now.

cblack edited the summary of this revision. (Show Details)Aug 1 2019, 1:21 AM

Hmm, now you've removed the 3.18 and 3.20 versions entirely in favor of a single 3.0 version. This change seems like it should be done in a separate patch.

In D22845#505092, @ngraham wrote:

Hmm, now you've removed the 3.18 and 3.20 versions entirely in favor of a single 3.0 version. This change seems like it should be done in a separate patch.

Closing this to reorganize revisions.

cblack abandoned this revision.Aug 1 2019, 3:29 PM

This is going to be fantastic, agreed on splitting up the patch.

"There are some other minor changes (radio buttons/checkboxes now sink in when clicking as their Qt counterparts do.)" - this should also be a separate patch

		Path
M		src/CMakeLists.txt (9 lines)
M		src/_colors.scss (198 lines)
M		src/_functions.scss (81 lines)
M		src/build_theme.sh (9 lines)
A	M	src/gtk-dark-3.0.css (1 line)
D	M	src/gtk-dark-3.18.css (1 line)
D	M	src/gtk-dark-3.20.css (1 line)
A	M	src/gtk-dark.css (1 line)
V		src/{gtk3 ← gtk320}/gtk.scss (2 lines)
V		src/{gtk3 ← gtk320}/widgets/_app_notifications.scss (4 lines)
V		src/{gtk3 ← gtk320}/widgets/_base.scss (124 lines)
V		src/{gtk3 ← gtk320}/widgets/_button.scss (132 lines)
A	M	src/gtk3/widgets/_calendar.scss (66 lines)
A	M	src/gtk3/widgets/_checkboxes.scss (108 lines)
V		src/{gtk3 ← gtk320}/widgets/_color_chooser.scss (8 lines)
A	M	src/gtk3/widgets/_dialogs.scss (50 lines)
V		src/{gtk3 ← gtk320}/widgets/_entry.scss (64 lines)
V		src/{gtk3 ← gtk320}/widgets/_headerbar.scss (69 lines)
A	M	src/gtk3/widgets/_infobar.scss (70 lines)
A	M	src/gtk3/widgets/_link.scss (57 lines)
A	M	src/gtk3/widgets/_lists.scss (69 lines)
A	M	src/gtk3/widgets/_menus.scss (328 lines)
V		src/{gtk3 ← gtk320}/widgets/_misc.scss (36 lines)
V		src/{gtk3 ← gtk320}/widgets/_notebook.scss (72 lines)
V		src/{gtk3 ← gtk320}/widgets/_overshoot.scss (16 lines)
V		src/{gtk3 ← gtk320}/widgets/_pathbar.scss (10 lines)
A	M	src/gtk3/widgets/_progressbar.scss (145 lines)
A	M	src/gtk3/widgets/_scale.scss (99 lines)
V		src/{gtk3 ← gtk320}/widgets/_scrollbar.scss (36 lines)
A	M	src/gtk3/widgets/_sidebar.scss (224 lines)
V		src/{gtk3 ← gtk320}/widgets/_spinbutton.scss (52 lines)
A	M	src/gtk3/widgets/_switch.scss (54 lines)
V		src/{gtk3 ← gtk320}/widgets/_toolbar.scss (14 lines)
V		src/{gtk3 ← gtk320}/widgets/_tooltips.scss (8 lines)
A	M	src/gtk3/widgets/_treeview.scss (169 lines)
V		src/{gtk3 ← gtk320}/widgets/_window_decorations.scss (2 lines)
D	M	src/gtk318/gtk.scss (33 lines)
D	M	src/gtk318/widgets/_app_notifications.scss (45 lines)
D	M	src/gtk318/widgets/_base.scss (210 lines)
D	M	src/gtk318/widgets/_button.scss (461 lines)
D	M	src/gtk318/widgets/_calendar.scss (66 lines)
D	M	src/gtk318/widgets/_checkboxes.scss (85 lines)
D	M	src/gtk318/widgets/_color_chooser.scss (98 lines)
D	M	src/gtk318/widgets/_dialogs.scss (36 lines)
D	M	src/gtk318/widgets/_entry.scss (119 lines)
D	M	src/gtk318/widgets/_headerbar.scss (159 lines)
D	M	src/gtk318/widgets/_infobar.scss (68 lines)
D	M	src/gtk318/widgets/_link.scss (42 lines)
D	M	src/gtk318/widgets/_lists.scss (106 lines)
D	M	src/gtk318/widgets/_menus.scss (160 lines)
D	M	src/gtk318/widgets/_misc.scss (112 lines)
D	M	src/gtk318/widgets/_notebook.scss (193 lines)
D	M	src/gtk318/widgets/_overshoot.scss (111 lines)
D	M	src/gtk318/widgets/_pathbar.scss (27 lines)
D	M	src/gtk318/widgets/_progressbar.scss (144 lines)
D	M	src/gtk318/widgets/_scale.scss (89 lines)
D	M	src/gtk318/widgets/_scrollbar.scss (93 lines)
D	M	src/gtk318/widgets/_sidebar.scss (74 lines)
D	M	src/gtk318/widgets/_spinbutton.scss (127 lines)
D	M	src/gtk318/widgets/_switch.scss (69 lines)
D	M	src/gtk318/widgets/_toolbar.scss (48 lines)
D	M	src/gtk318/widgets/_tooltips.scss (30 lines)
D	M	src/gtk318/widgets/_treeview.scss (138 lines)
D	M	src/gtk318/widgets/_window_decorations.scss (176 lines)
V		src/{gtk320 → gtk3}/gtk.scss
V		src/{gtk320 → gtk3}/widgets/_app_notifications.scss
V		src/{gtk320 → gtk3}/widgets/_base.scss
V		src/{gtk320 → gtk3}/widgets/_button.scss
D	M	src/gtk320/widgets/_calendar.scss (66 lines)
D	M	src/gtk320/widgets/_checkboxes.scss (81 lines)
V		src/{gtk320 → gtk3}/widgets/_color_chooser.scss
D	M	src/gtk320/widgets/_dialogs.scss (46 lines)
V		src/{gtk320 → gtk3}/widgets/_entry.scss
V		src/{gtk320 → gtk3}/widgets/_headerbar.scss
D	M	src/gtk320/widgets/_infobar.scss (68 lines)
D	M	src/gtk320/widgets/_link.scss (51 lines)
D	M	src/gtk320/widgets/_lists.scss (50 lines)
D	M	src/gtk320/widgets/_menus.scss (253 lines)
V		src/{gtk320 → gtk3}/widgets/_misc.scss
V		src/{gtk320 → gtk3}/widgets/_notebook.scss
V		src/{gtk320 → gtk3}/widgets/_overshoot.scss
V		src/{gtk320 → gtk3}/widgets/_pathbar.scss
D	M	src/gtk320/widgets/_progressbar.scss (141 lines)
D	M	src/gtk320/widgets/_scale.scss (94 lines)
V		src/{gtk320 → gtk3}/widgets/_scrollbar.scss
D	M	src/gtk320/widgets/_sidebar.scss (124 lines)
V		src/{gtk320 → gtk3}/widgets/_spinbutton.scss
D	M	src/gtk320/widgets/_switch.scss (54 lines)
V		src/{gtk320 → gtk3}/widgets/_toolbar.scss
V		src/{gtk320 → gtk3}/widgets/_tooltips.scss
D	M	src/gtk320/widgets/_treeview.scss (140 lines)
V		src/{gtk320 → gtk3}/widgets/_window_decorations.scss

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62822	a581f32		Jul 31 2019, 12:32 AM	★	★
Diff 2	62824	a581f32	Forgot about changing the build_theme.sh to export to my home directory under…	Jul 31 2019, 12:36 AM	★	★
Diff 3	62825	a581f32	Good job at picking up that change, arc. See previous change.	Jul 31 2019, 12:37 AM	★	★
Diff 4	62858	a581f32	Fix some issues with incorrect colors being used	Jul 31 2019, 2:45 PM	★	★
Diff 5	62881	a581f32	Fix CMakeLists.txt	Aug 1 2019, 1:06 AM	★	★
Diff 6	62882	a581f32	Forgot to add you	Aug 1 2019, 1:07 AM	★	★

[GTK3] Convert all colors to use GTK color definitionsAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 62882

src/CMakeLists.txt

src/_colors.scss

src/_functions.scss

src/build_theme.sh

src/gtk-dark-3.0.css

src/gtk-dark-3.18.css

src/gtk-dark-3.20.css

src/gtk-dark.css

src/gtk3/gtk.scss

src/gtk3/widgets/_app_notifications.scss

src/gtk3/widgets/_base.scss

src/gtk3/widgets/_button.scss

src/gtk3/widgets/_calendar.scss

src/gtk3/widgets/_checkboxes.scss

src/gtk3/widgets/_color_chooser.scss

src/gtk3/widgets/_dialogs.scss

src/gtk3/widgets/_entry.scss

src/gtk3/widgets/_headerbar.scss

src/gtk3/widgets/_infobar.scss

src/gtk3/widgets/_link.scss

src/gtk3/widgets/_lists.scss

src/gtk3/widgets/_menus.scss

src/gtk3/widgets/_misc.scss

src/gtk3/widgets/_notebook.scss

src/gtk3/widgets/_overshoot.scss

src/gtk3/widgets/_pathbar.scss

src/gtk3/widgets/_progressbar.scss

src/gtk3/widgets/_scale.scss

src/gtk3/widgets/_scrollbar.scss

src/gtk3/widgets/_sidebar.scss

src/gtk3/widgets/_spinbutton.scss

src/gtk3/widgets/_switch.scss

src/gtk3/widgets/_toolbar.scss

src/gtk3/widgets/_tooltips.scss

src/gtk3/widgets/_treeview.scss

src/gtk3/widgets/_window_decorations.scss

src/gtk318/gtk.scss

src/gtk318/widgets/_app_notifications.scss

src/gtk318/widgets/_base.scss

src/gtk318/widgets/_button.scss

src/gtk318/widgets/_calendar.scss

src/gtk318/widgets/_checkboxes.scss

src/gtk318/widgets/_color_chooser.scss

src/gtk318/widgets/_dialogs.scss

src/gtk318/widgets/_entry.scss

src/gtk318/widgets/_headerbar.scss

src/gtk318/widgets/_infobar.scss

src/gtk318/widgets/_link.scss

src/gtk318/widgets/_lists.scss

src/gtk318/widgets/_menus.scss

src/gtk318/widgets/_misc.scss

src/gtk318/widgets/_notebook.scss

src/gtk318/widgets/_overshoot.scss

src/gtk318/widgets/_pathbar.scss

src/gtk318/widgets/_progressbar.scss

src/gtk318/widgets/_scale.scss

src/gtk318/widgets/_scrollbar.scss

src/gtk318/widgets/_sidebar.scss

src/gtk318/widgets/_spinbutton.scss

src/gtk318/widgets/_switch.scss

src/gtk318/widgets/_toolbar.scss

src/gtk318/widgets/_tooltips.scss

src/gtk318/widgets/_treeview.scss

src/gtk318/widgets/_window_decorations.scss

src/gtk320/gtk.scss

src/gtk320/widgets/_app_notifications.scss

src/gtk320/widgets/_base.scss

src/gtk320/widgets/_button.scss

src/gtk320/widgets/_calendar.scss

src/gtk320/widgets/_checkboxes.scss

src/gtk320/widgets/_color_chooser.scss

src/gtk320/widgets/_dialogs.scss

src/gtk320/widgets/_entry.scss

src/gtk320/widgets/_headerbar.scss

src/gtk320/widgets/_infobar.scss

[GTK3] Convert all colors to use GTK color definitions
AbandonedPublic
Actions

Revision Contents
Changeset List