Use wayland platform plugin on Gnome
ClosedPublic
Actions

Authored by jgrulich on Jul 30 2019, 2:05 PM.

Details

Reviewers

Commits

R257:d2db53cd1024: Use wayland platform plugin on Gnome

Summary

QWayland is automatically used on all desktops besided Gnome, but it already works just fine there. We also
should use a gnome platform theme when possible (e.g. QGnomePlatform) for better Gnome integration. Using
wayland makes Qt apps on Gnome wayland sessions to better support HiDPI and also applications using
--socket=fallback-x11 will not fail to start

Diff Detail

Repository

R257 Flatpak packaging for KDE Platform and Sdk

Branch

qt5.12lts

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14572
Build 14590: arc lint + arc unit

jgrulich requested review of this revision.Jul 30 2019, 2:05 PM

jgrulich created this revision.

Harbormaster completed remote builds in B14572: Diff 62793.Jul 30 2019, 2:05 PM

jgrulich added a reviewer: apol.Jul 30 2019, 2:07 PM

Can we get this upstream? If it works for us it should work for everyone.

In D22829#504209, @apol wrote:

Can we get this upstream? If it works for us it should work for everyone.

I'm not sure whether this will be approved by upstream, because there is no native decoration support for Gnome. I have almost ready decorations implemented in QGnomePlatform, which I will update in Flathub soon, but distributions which don't use it or users who don't have QGnomePlatform installed will have just basic decorations provided by QWayland.

In D22829#504210, @jgrulich wrote:

In D22829#504209, @apol wrote:

Can we get this upstream? If it works for us it should work for everyone.

I'm not sure whether this will be approved by upstream, because there is no native decoration support for Gnome. I have almost ready decorations implemented in QGnomePlatform, which I will update in Flathub soon, but distributions which don't use it or users who don't have QGnomePlatform installed will have just basic decorations provided by QWayland.

Maybe it's a good reason for these distros to bring QGnomePlatform then.

In D22829#504209, @apol wrote:

Can we get this upstream? If it works for us it should work for everyone.

Ok, let's see:

The third patch was already upstreamed, I took it from "dev" branch.

Aleix, do you think we can get this merged? It might take a while to get this upstreamed and it's pretty annoying to have Qt apps use xcb plugin on Gnome wayland when you use HiDPI display, it forces me to set everything manually.

apol accepted this revision.Aug 6 2019, 10:53 AM

This revision is now accepted and ready to land.Aug 6 2019, 10:53 AM

jgrulich closed this revision.Aug 6 2019, 11:09 AM

Revision Contents
Changeset List

		Path
M		org.kde.Sdk.json (12 lines)
A	M	patch/qtbase-use-wayland-on-gnome.patch (20 lines)
A	M	patch/qtwayland-do-not-redraw-decorations-everytime.patch (33 lines)
A	M	patch/qtwayland-use-gnome-platform-theme-on-gnome-based-desktops.patch (39 lines)