Differential D22765

Docs: fix bad example code
ClosedPublic
Actions

Authored by adridg on Jul 26 2019, 3:15 PM.

Details

Reviewers
davidedmundson
Commits
R296:2d39e2f0ad56: Docs: fix bad example code
Summary
  • setupBindings() doesn't take an engine parameter
  • setupBindings() is deprecated and suggests to call setupContext() instead, although you need to setup the engine as well and tell KDeclarative to use that engine.
Test Plan
  • the previous example code wouldn't compile

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adridg created this revision.Jul 26 2019, 3:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 26 2019, 3:15 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
adridg requested review of this revision.Jul 26 2019, 3:15 PM
davidedmundson accepted this revision.Jul 26 2019, 3:48 PM
This revision is now accepted and ready to land.Jul 26 2019, 3:48 PM
Closed by commit R296:2d39e2f0ad56: Docs: fix bad example code (authored by adridg). · Explain WhyJul 26 2019, 8:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MREADME.md (24 lines)

Diff 62623

View Options

README.md

Loading...