Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly
ClosedPublic

Authored by fvogt on Jul 26 2019, 7:06 AM.

Details

Summary

Currently KRunner uses QObjectDecorator wrongly and changing the
design to fix that would not only be a lot of work, but also include downsides
like having two custom Job classes, making the code harder to read.
So merge the part of QObjectDecorator that would've been used here into the
FindMatchesJob class and drop use of QObjectDecorator.

Test Plan

Added a debug statement in the jobDone slot, it's called.

Diff Detail

Repository
R308 KRunner
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Jul 26 2019, 7:06 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 26 2019, 7:06 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
fvogt requested review of this revision.Jul 26 2019, 7:06 AM
davidedmundson accepted this revision.Aug 21 2019, 11:28 AM
This revision is now accepted and ready to land.Aug 21 2019, 11:28 AM
davidedmundson requested changes to this revision.Aug 21 2019, 11:49 AM

Edit. On testing this doesn't seem to work.
See runnertest (with D23314)

This revision now requires changes to proceed.Aug 21 2019, 11:49 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Aug 21 2019, 11:58 AM
This revision was automatically updated to reflect the committed changes.