whitelist the "turn off screen" shortcut on the lock screen
ClosedPublic

Authored by mblumenstingl on Jul 25 2019, 7:55 PM.

Details

Summary

This is a follow-up to D22261

unfortunately the test plan is not working for me:
when I press the global shortcut on the lock screen then the display does not turn off.
however, this is not related to the new global action because "volume up", "volume down", "mute" and "play pause" are also not working for me on the lock screen

Test Plan

start a plasma wayland session
open systemsettings5 -> Shortcuts -> Global Shortcuts -> Power Management
assign a shortcut to "Turn Off Screen"
press this shortcut
(screen must now turn off -> this confirms that the shortcut is working)
move the mouse or press a key to turn the screen back on
lock the screen
press the global shortcut again
(screen must now turn off)

Diff Detail

Repository
R133 KScreenLocker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

I did some more digging and I now believe that I'm facing a problem that's related to me running wayland.

https://github.com/KDE/kwindowsystem/blob/05f5379c24a59e1ded2f12a6fd09946617abd0ac/src/kkeyserver.h#L29
KKeyServer has a compile-time switch for it's backend.
I guess this needs to be converted to a runtime switch similar to what was done here https://github.com/KDE/kguiaddons/commit/0fe2990dbad992a4925a7b7bee09b1cdfbe5a7a7#diff-928c366533ef47aba95b92e8767bc8ff

I did some more digging and I now believe that I'm facing a problem that's related to me running wayland.

https://github.com/KDE/kwindowsystem/blob/05f5379c24a59e1ded2f12a6fd09946617abd0ac/src/kkeyserver.h#L29
KKeyServer has a compile-time switch for it's backend.
I guess this needs to be converted to a runtime switch similar to what was done here https://github.com/KDE/kguiaddons/commit/0fe2990dbad992a4925a7b7bee09b1cdfbe5a7a7#diff-928c366533ef47aba95b92e8767bc8ff

there's even a task on phabricator for this: T4423

davidedmundson accepted this revision.Jul 25 2019, 9:10 PM
This revision is now accepted and ready to land.Jul 25 2019, 9:10 PM
This revision was automatically updated to reflect the committed changes.