Differential D22701

[kfileutils] Add isExecutableFile from KRun
AbandonedPublic
Actions

Authored by nicolasfella on Jul 23 2019, 8:48 PM.

Details

Reviewers
dfaure
Summary

isExecutableFile is a useful function independent of KRun. Move it here so it can be used without pulling in all of KRun

Test Plan

builds

Diff Detail

Repository
R244 KCoreAddons
Branch
exefile
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14350
Build 14368: arc lint + arc unit
nicolasfella created this revision.Jul 23 2019, 8:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 23 2019, 8:48 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 23 2019, 8:48 PM
dfaure added a comment.Jul 24 2019, 9:23 PM

I started to write a KIO::OpenUrlJob, as a core-only version of KRun. I think this method actually belongs there, because it means "can be executed by KRun" (or soon OpenUrlJob).
In isolation I don't think this method is useful. I looked at all users of this method on lxr.kde.org and they all check this in connection with KRun.
With this in mind, is there still a good reason to move it to kfileutils?

src/lib/io/kfileutils.h
48

Please remove the docu starting from this line to the end (i.e. 48-52), it describes KDE3 mimetype desktop files...

nicolasfella abandoned this revision.Apr 20 2020, 10:53 AM

Revision Contents
Changeset List

PathPackages
Msrc/lib/io/kfileutils.h (14 lines)
Msrc/lib/io/kfileutils.cpp (23 lines)

Diff 62440

View Options

src/lib/io/kfileutils.h

Loading...
View Options

src/lib/io/kfileutils.cpp

Loading...