Differential D22685

Fix failing autotest
ClosedPublic
Actions

Authored by zzag on Jul 23 2019, 2:09 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Frameworks
Commits
R278:14998613603c: Fix failing autotest
Summary

KWindowInfoX11Test fails because some parts of QXcbWindow were changed in
Qt 5.12.X:

  • Since Qt 5.12.1, QXcbWindow sets WM_CLIENT_LEADER property for all clients;
  • Since Qt 5.12.0, QXcbWindow sets WM_CLIENT_MACHINE property.

Diff Detail

Repository
R278 KWindowSystem
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Jul 23 2019, 2:09 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 23 2019, 2:09 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.Jul 23 2019, 2:09 PM
zzag updated this revision to Diff 62397.Jul 23 2019, 2:13 PM

Require XCB::ICCCM in autotests/CMakeLists.txt

zzag edited the summary of this revision. (Show Details)Jul 23 2019, 2:14 PM
zzag edited the summary of this revision. (Show Details)
zzag updated this revision to Diff 62399.Jul 23 2019, 2:16 PM

Simplify a bit

zzag updated this revision to Diff 62404.Jul 23 2019, 2:37 PM

Check initial value of group leader.

zzag retitled this revision from Fix failing autotests to Fix failing autotest.Jul 23 2019, 2:38 PM
zzag updated this revision to Diff 62406.Jul 23 2019, 2:48 PM

Make hostnames in testClientMachine unique.

davidedmundson accepted this revision.Jul 23 2019, 2:52 PM
This revision is now accepted and ready to land.Jul 23 2019, 2:52 PM
Closed by commit R278:14998613603c: Fix failing autotest (authored by zzag). · Explain WhyJul 23 2019, 2:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62407

View Options

autotests/CMakeLists.txt

Loading...
View Options

autotests/kwindowinfox11test.cpp

Loading...