Add common GLSL file extensions (.vs, .gs, .fs)
ClosedPublic

Authored by smokris on Jul 22 2019, 7:43 PM.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Lint Skipped
Unit
Unit Tests Skipped
smokris created this revision.Jul 22 2019, 7:43 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. ยท View Herald TranscriptJul 22 2019, 7:43 PM
smokris requested review of this revision.Jul 22 2019, 7:43 PM
cullmann requested changes to this revision.Aug 13 2019, 7:53 PM
cullmann added a subscriber: cullmann.

I am not sure we want to override F# for .fs.
Either we should not add that or we shall lower the priority of this highlighting to loose against F#.

This revision now requires changes to proceed.Aug 13 2019, 7:53 PM
smokris requested review of this revision.Aug 13 2019, 8:13 PM

I am not sure we want to override F# for .fs.
Either we should not add that or we shall lower the priority of this highlighting to loose against F#.

The test I added verifies that F# is still being chosen for the .fs extension (and that GLSL, added by this change, loses to F#'s higher priority).

cullmann accepted this revision.Aug 13 2019, 8:18 PM

Sorry, then I did misread that in the diff, I thought QTest::newRow("fs") << QStringLiteral("test.fs") << QStringLiteral("FSharp"); enforces that FSharp is used, not the other way around ;=)

This revision is now accepted and ready to land.Aug 13 2019, 8:18 PM

If you pass me name + email, will push it.

Sounds good, thanks. I just emailed you at your KDE address.

cullmann closed this revision.Aug 13 2019, 8:24 PM