Differential D22650

Use KDE_INSTALL_LOGGINGCATEGORIESDIR in ECM 5.59
ClosedPublic
Actions

Authored by fvogt on Jul 22 2019, 2:48 PM.

Details

Reviewers
vkrause
Commits
R1032:f8aef3114579: Use KDE_INSTALL_LOGGINGCATEGORIESDIR in ECM 5.59
Summary

KDE_INSTALL_LOGGINGCATEGORIESDIR is provided for this use case now.

Test Plan

Installed, worked.

Diff Detail

Repository
R1032 KPublicTransport
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt requested review of this revision.Jul 22 2019, 2:48 PM
fvogt created this revision.
fvogt edited the summary of this revision. (Show Details)Jul 22 2019, 3:10 PM
vkrause accepted this revision.Jul 23 2019, 9:12 AM

Thanks!

This revision is now accepted and ready to land.Jul 23 2019, 9:12 AM
fvogt added a comment.Jul 23 2019, 9:16 AM

(Somewhat OT) I asked dfaure about the header file installation and it's split correctly as kpublictransport is namespaced and this way the include paths match the classes.

Closed by commit R1032:f8aef3114579: Use KDE_INSTALL_LOGGINGCATEGORIESDIR in ECM 5.59 (authored by fvogt). · Explain WhyJul 23 2019, 9:20 AM
This revision was automatically updated to reflect the committed changes.
vkrause added a comment.Jul 23 2019, 9:45 AM
In D22650#500685, @fvogt wrote:

(Somewhat OT) I asked dfaure about the header file installation and it's split correctly as kpublictransport is namespaced and this way the include paths match the classes.

Thanks, then we still have a bug though, just in different modules :) prison is all lower case, syntax-highlighting is all upppercase, kcontacts/kcalcore have another level of directories, etc..

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)
Msrc/CMakeLists.txt (2 lines)

Diff 62377

View Options

CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...