Differential D22641

Inject content script also into about:blank
ClosedPublic
Actions

Authored by broulik on Jul 22 2019, 12:09 PM.

Details

Reviewers
fvogt
Group Reviewers
Plasma
Commits
R856:ed5982697c83: Inject content script also into about:blank
Summary

A completely dynamically created <iframe> might not have a source but default to about:blank with its content being added by JavaScript. In this case our extension would not be executed in said iframe.

Test Plan

Extension is executed in that kaltura player thing heise uses, see the video on [1]

[1] https://www.heise.de/newsticker/meldung/Star-Trek-Picard-Neuer-Trailer-mit-alten-Bekannten-4475986.html

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 22 2019, 12:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 22 2019, 12:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
fvogt added a comment.Jul 22 2019, 1:02 PM

An iframe without source, the things web devs come up with...

fvogt accepted this revision.Jul 22 2019, 1:03 PM
This revision is now accepted and ready to land.Jul 22 2019, 1:03 PM
Closed by commit R856:ed5982697c83: Inject content script also into about:blank (authored by broulik). · Explain WhyJul 22 2019, 1:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/manifest.json (3 lines)

Diff 62288

View Options

extension/manifest.json

Loading...