Differential D22642

Monitor entire document rather than the documentElement specifically
ClosedPublic
Actions

Authored by broulik on Jul 22 2019, 12:11 PM.

Details

Reviewers
fvogt
Group Reviewers
Plasma
Commits
R856:88f2da50b640: Monitor entire document rather than the documentElement specifically
Summary

Calling document.write will replace the entire documentElement with a new one, effectively removing our mutation observers.

Test Plan

Together with D22641 I can now successfully control that kaltura player thing heise uses, see the video on [1].
Normal website is still monitored correctly

[1] https://www.heise.de/newsticker/meldung/Star-Trek-Picard-Neuer-Trailer-mit-alten-Bekannten-4475986.html

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 22 2019, 12:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 22 2019, 12:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 22 2019, 12:11 PM
fvogt accepted this revision.Jul 22 2019, 1:01 PM
This revision is now accepted and ready to land.Jul 22 2019, 1:01 PM
Closed by commit R856:88f2da50b640: Monitor entire document rather than the documentElement specifically (authored by broulik). · Explain WhyJul 22 2019, 1:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mextension/content-script.js (2 lines)

Diff 62289

View Options

extension/content-script.js

Loading...