Differential D22622

Calendar formatter: port to PimUniqueApplication::activateApplication
ClosedPublic
Actions

Authored by dfaure on Jul 21 2019, 6:06 PM.

Details

Reviewers
vkrause
dvratil
mlaurent
Commits
R81:7c4e6a866dd3: Calendar formatter: port to PimUniqueApplication::activateApplication
Summary

The whole "if korganizer or kontact is running, bring it to the front, otherwise
start korganizer" logic becomes a single line of code.
I'm not 100% sure about the Windows code using QProcess; clearly it
relies on DBus anyway so the new way should work, but it mentions
korganizer-mobile.sh (which could be called by the DBus service file then...)

Test Plan

Click "Check My Calendar" in an invitation email.
In KMail, it starts standalone korganizer.
In Kontact, it switches to the calendar plugin.

Diff Detail

Repository
R81 KDE PIM Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Jul 21 2019, 6:06 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 21 2019, 6:06 PM
dfaure requested review of this revision.Jul 21 2019, 6:06 PM
vkrause accepted this revision.Jul 21 2019, 9:43 PM
This revision is now accepted and ready to land.Jul 21 2019, 9:43 PM
Closed by commit R81:7c4e6a866dd3: Calendar formatter: port to PimUniqueApplication::activateApplication (authored by dfaure). · Explain WhyJul 21 2019, 10:31 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 62252