Add function to suggest a unique filename
ClosedPublic
Actions

Authored by nicolasfella on Jul 21 2019, 6:00 PM.

Details

Reviewers

Commits

R244:03b9bdee4f52: Add function to suggest a unique filename

Summary

This is a copy of KIO::suggestName. It doesn't use anything from KIO in its implementation and this patch enables to use it without pulling in all the baggage that comes with KIO

Test Plan

Port the one use in KDE Connect to it

Diff Detail

Repository

R244 KCoreAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Jul 21 2019, 6:00 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJul 21 2019, 6:00 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Jul 21 2019, 6:00 PM

Harbormaster completed remote builds in B14221: Diff 62215.Jul 21 2019, 6:00 PM

Please "move" (copy) the autotest as well, see kio/autotests/globaltest.cpp

Typo in the commit log: s/it's/its/

This revision now requires changes to proceed.Jul 21 2019, 6:21 PM

Add test

Harbormaster completed remote builds in B14224: Diff 62218.Jul 21 2019, 6:32 PM

nicolasfella edited the summary of this revision. (Show Details)Jul 21 2019, 6:33 PM

dfaure requested changes to this revision.Jul 21 2019, 6:40 PM

dfaure added inline comments.

autotests/kfileutilstest.cpp
3	Liar :-) I wrote the first version of this test method.
src/lib/io/kfileutils.cpp
3	ditto
65	You can remove this TODO. By moving this code to KCoreAddons we are finally closing the lid on this TODO. It just won't be done, it wouldn't be a good idea anyway (too slow, and would require an async API, and a KIO dependency). So if it's ever done, it'll be with a different implementation in KIO, while this one will remain the "simple and synchronous" way, sufficient for many apps.

This revision now requires changes to proceed.Jul 21 2019, 6:40 PM

Don't steal David's copyright
Remove TODO

Harbormaster completed remote builds in B14227: Diff 62222.Jul 21 2019, 6:46 PM

dfaure accepted this revision.Jul 21 2019, 6:51 PM

This revision is now accepted and ready to land.Jul 21 2019, 6:51 PM

Closed by commit R244:03b9bdee4f52: Add function to suggest a unique filename (authored by nicolasfella). · Explain WhyJul 21 2019, 6:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/CMakeLists.txt (1 line)
A	M	autotests/kfileutilstest.h (34 lines)
A	M	autotests/kfileutilstest.cpp (65 lines)
M		src/lib/CMakeLists.txt (2 lines)
A	M	src/lib/io/kfileutils.h (43 lines)
A	M	src/lib/io/kfileutils.cpp (73 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62215	18b54cd		Jul 21 2019, 6:00 PM	★	★
Diff 2	62218	18b54cd	- Add test	Jul 21 2019, 6:32 PM	★	★
Diff 3	62222	18b54cd	- Don't steal David's copyright	Jul 21 2019, 6:46 PM	★	★
Diff 4	62223	18b54cd	R244:03b9bdee4f5204af483df3897de1ade2d77596e2	Jul 21 2019, 6:51 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
92f072bce5b0	95b3d4f14313	123a66c1e838	Nicolas Fella	Remove TODO	Jul 21 2019, 6:46 PM
123a66c1e838	a6723dbe6374	1d0676897b1f	Nicolas Fella	Don't steal David's copyright	Jul 21 2019, 6:45 PM
1d0676897b1f	3c9f3acc0dac	35bd3b364a10	Nicolas Fella	Add test	Jul 21 2019, 6:32 PM
35bd3b364a10	aeb2ee95fed6	18b54cddda24	Nicolas Fella	Add function to suggest a unique filename (Show More…)	Jul 21 2019, 5:57 PM