Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON)
ClosedPublic
Actions

Authored by kossebau on Jul 20 2019, 1:48 PM.

Details

Reviewers

Commits

R300:6d14a648156e: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON)

Summary

Being a "Porting Aids", the KF tier3 kdesignerplugin can no longer
do the service of providing such a plugin, as this means depending on us.
So we serve ourselve here for those still using KDEWebKit and preferring
to have a proper representation when using Qt Designer.

Test Plan

Building with BUILD_DESIGNERPLUGIN=ON generates a working plugin,
which appears in "Views (KDE - Deprecated)" group.
Still also builds with BUILD_DESIGNERPLUGIN=OFF

Diff Detail

Repository

R300 KDEWebKit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Jul 20 2019, 1:48 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJul 20 2019, 1:48 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Jul 20 2019, 1:48 PM

Harbormaster completed remote builds in B14164: Diff 62114.Jul 20 2019, 1:48 PM

Comparing with kdelibs4support, there the designer plugin is always build,
so defaulting BUILD_DESIGNERPLUGIN=ON feels more consistent

Harbormaster completed remote builds in B14168: Diff 62118.Jul 20 2019, 2:00 PM

kossebau retitled this revision from Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default off) to Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON).Jul 20 2019, 2:01 PM

kossebau edited the test plan for this revision. (Show Details)

apol accepted this revision.Jul 20 2019, 2:21 PM

This revision is now accepted and ready to land.Jul 20 2019, 2:21 PM

Closed by commit R300:6d14a648156e: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON) (authored by kossebau). · Explain WhyJul 20 2019, 9:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (6 lines)
M		src/CMakeLists.txt (3 lines)
A	M	src/designer/CMakeLists.txt (17 lines)
A	M	src/designer/kdewebkit.widgets (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62114	8a7f772		Jul 20 2019, 1:48 PM	★	★
Diff 2	62118	8a7f772	Comparing with kdelibs4support, there the designer plugin is always build,	Jul 20 2019, 2:00 PM	★	★
Diff 3	62156	8a7f772	R300:6d14a648156e06dd91ef863c59dfbfd65105a5b4	Jul 20 2019, 9:45 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
6b3140223a6c	cda3bd498d2a	d8a5fc4e3cc6	Friedrich W. H. Kossebau	Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON) (Show More…)	Jul 20 2019, 1:45 PM
d8a5fc4e3cc6	63ff9910deb0	8a7f7726f2c4	Friedrich W. H. Kossebau	Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default off) (Show More…)	Jul 20 2019, 1:45 PM