Differential D2258

Do not detect kde4 directory but assume it is the same location, this means people who install as non-root with kde-srcbuild can install it
ClosedPublic
Actions

Authored by jriddell on Jul 22 2016, 10:37 AM.

Details

Reviewers
sebas
dfaure
Group Reviewers
Plasma
Commits
R994:755ca00bbd13: Do not detect kde4 directory but assume it is the same location, this means…
R115:755ca00bbd13: Do not detect kde4 directory but assume it is the same location, this means…
Summary

Do not detect global kde4 directory

Test Plan

run make install

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jriddell updated this revision to Diff 5426.Jul 22 2016, 10:37 AM
jriddell retitled this revision from to Do not detect kde4 directory but assume it is the same location, this means people who install as non-root with kde-srcbuild can install it.
jriddell updated this object.
jriddell edited the test plan for this revision. (Show Details)
jriddell added reviewers: dfaure, sebas.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 22 2016, 10:37 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dfaure accepted this revision.Jul 24 2016, 10:04 AM
dfaure edited edge metadata.

Thanks.

Installing outside the install prefix is against the law.

This revision is now accepted and ready to land.Jul 24 2016, 10:04 AM
Closed by commit R115:755ca00bbd13: Do not detect kde4 directory but assume it is the same location, this means… (authored by jriddell). · Explain WhyJul 25 2016, 1:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdata/CMakeLists.txt (15 lines)

Diff 5488

View Options

data/CMakeLists.txt

Loading...