The stylesheet was added to hide what looks like an expand/close indicator
on a tree that is always expanded (setItemsExpandable(false)).
On the other hand, the use of a stylesheet at all introduced these two
bugs: changing the font globally (kcmshell5 fonts) or the colors
(kcmshell5 color) would work on most of zanshin EXCEPT on the treeview
in the middle, which kept the old palette or the old font. Awful.
Redone with a proxy style to avoid these issues.
kcmshell5 colors now applies the colors to all of zanshin
| No Linters Available |
| No Unit Test Coverage |
| Buildable 14173 | |
| Build 14191: arc lint + arc unit |
Honestly, I'm not too thrilled about that. I'm surprised about the mentioned bugs from stylesheets though, I thought it was proxying to the real style nowadays?
Any alternative to not having those rendered? It's a question of visual clutter.
It is proxying the real style (it always has been), but it sets a custom palette and font, at creation time, which breaks reacting to changes to those.
(proof, see QStyleSheetStyle::polish => QStyleSheetStyle::setPalette => w->setPalette(p))
We could listen to QEvent::ApplicationPaletteChange but since stylesheets also break QWidget::setPalette, we would probably have to unset and set the stylesheet again. Horrible. One of the many reasons why I hate stylesheets.
Ah, hmm, the alternative is a proper proxy style, without the stylesheet crap.
Oh, right, so it follows styling but just doesn't react to change. It's minor enough that I'd be willing to just ignore it. Otherwise we're good for the proxy style route...
Redone with a proxy style.
We want nothing, right? No close icon, but also no lines connecting parent and child?