Differential D22574

Re-map default "Switch input mode" shortcut to not confict with konsolepart
ClosedPublic
Actions

Authored by ngraham on Jul 20 2019, 1:54 AM.

Details

Reviewers
cullmann
Group Reviewers
Kate
KTextEditor
Commits
R39:0fb0e618bb0c: Re-map default "Switch input mode" shortcut to not confict with konsolepart
Summary

kateview's "Switch input mode" feature is currently bound to Ctrl+⇧+V. This
causes two problems:

  1. When the embedded konsolepart is visible, both it and Kate claim the same shortcut so neither one works
  2. At other times, it's easily possible to accidentally enter vi mode when you mean to paste due to residual muscle memory from having pasted test in Konsole recently

For these reasons, this patch changes the default shortcut to Ctrl+Alt+V, which
is also kind of more elegant anyway since it now uses the Alt key and triggers
alternate input modes.

BUG: 409978
FIXED-IN: 5.61

Test Plan
  1. Compile
  2. Open Kate
  3. Hit Ctrl+⇧+V and see that nothing happens
  4. Copy some text
  5. Open embedded Konsole and paste text with Ctrl+⇧+V and see that it works
  6. Hit Ctrl+Alt+V and see that it enters vi mode

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jul 20 2019, 1:54 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJul 20 2019, 1:54 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 20 2019, 1:54 AM
ngraham edited the summary of this revision. (Show Details)Jul 20 2019, 1:55 AM
ngraham added reviewers: Kate, KTextEditor.
cullmann accepted this revision.Jul 20 2019, 6:58 AM
cullmann added a subscriber: cullmann.

Very reasonable! Thanks.

This revision is now accepted and ready to land.Jul 20 2019, 6:58 AM
Closed by commit R39:0fb0e618bb0c: Re-map default "Switch input mode" shortcut to not confict with konsolepart (authored by ngraham). · Explain WhyJul 20 2019, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/view/kateview.cpp (2 lines)

Diff 62113

View Options

src/view/kateview.cpp

Loading...