Differential D22572

Remove scaling of iconsize unit for isMobile
ClosedPublic
Actions

Authored by camiloh on Jul 19 2019, 9:10 PM.

Details

Reviewers
mart
ngraham
Group Reviewers
VDG
Commits
R169:a89b2334f137: Remove scaling of iconsize unit for isMobile
Summary

On Android icons using the iconSizes units look too big for the intended size, this change has been tested on different screen sizes with devices running Android and also on a Nexus 5x running Plamo, and the result is goo. I'm attaching the resulting screenshots and screencast.



on a 3.5" screen. Also, the big icons would be an issue on such small screens, since they would take all the space and everything would look too bulky.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
camiloh created this revision.Jul 19 2019, 9:10 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptJul 19 2019, 9:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
camiloh requested review of this revision.Jul 19 2019, 9:10 PM
camiloh edited the summary of this revision. (Show Details)Jul 19 2019, 9:13 PM
camiloh edited the summary of this revision. (Show Details)Jul 19 2019, 9:15 PM
camiloh added a reviewer: mart.
camiloh edited the summary of this revision. (Show Details)
ngraham accepted this revision.Jul 19 2019, 9:24 PM
This revision is now accepted and ready to land.Jul 19 2019, 9:24 PM
mart accepted this revision.Jul 22 2019, 12:25 PM
Closed by commit R169:a89b2334f137: Remove scaling of iconsize unit for isMobile (authored by camiloh). · Explain WhyJul 22 2019, 12:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/Units.qml (12 lines)

Diff 62285

View Options

src/controls/Units.qml

Loading...