Differential D22569

[Dialog] Apply window type after changing flags
ClosedPublic
Actions

Authored by broulik on Jul 19 2019, 8:44 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:67811e152a67: [Dialog] Apply window type after changing flags
Summary

Changing flags might override the window type, ensure we set it back properly

Test Plan

Changed window flags, dialog had the correct type again afterwards. KWin doesn't handle this properly but I'm on it. It's in preparation for notification quick reply feature

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 19 2019, 8:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 19 2019, 8:44 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Jul 19 2019, 8:44 PM
mart accepted this revision.Sep 3 2019, 10:25 AM
This revision is now accepted and ready to land.Sep 3 2019, 10:25 AM
Closed by commit R242:67811e152a67: [Dialog] Apply window type after changing flags (authored by broulik). · Explain WhySep 16 2019, 6:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasmaquick/dialog.cpp (60 lines)

Diff 66183

View Options

src/plasmaquick/dialog.cpp

Loading...