Differential D22550

Make Prison optional
ClosedPublic
Actions

Authored by broulik on Jul 19 2019, 8:05 AM.

Details

Reviewers
jgrulich
apol
Group Reviewers
Plasma
Commits
R116:00c78ced6c03: Make Prison optional
Summary

Don't break the entire network applet just because org.kde.prison isn't available.
When opening the context menu, it creates the Component and if it failed to load, the menu entry isn't shown

Test Plan

Barcode doesnt show if qml file doesnt load
Barcode shows fine otherwise

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 19 2019, 8:05 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 19 2019, 8:05 AM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 19 2019, 8:05 AM
jgrulich accepted this revision.Jul 19 2019, 8:46 AM
This revision is now accepted and ready to land.Jul 19 2019, 8:46 AM
Closed by commit R116:00c78ced6c03: Make Prison optional (authored by broulik). · Explain WhyJul 19 2019, 9:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62035

View Options

applet/contents/ui/ConnectionItem.qml

Loading...