Details
Details
- Reviewers
nienhueser rahn
Diff Detail
Diff Detail
- Repository
- R34 Marble
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Looks good :-)
To make this really shine we need some improvements in the webpopup implementation, me thinks. @rahn Any ideas? Pain points I see currently are
- the size of the webpopup is often wrong: Too small (does not fit the content well) or even too large (content/size ratio seems low)
- it feels heavy
- it involves a lot of automatic map panning
| src/lib/marble/MarbleMap.h | ||
|---|---|---|
| 424 ↗ | (On Diff #5474) | Let's provide a const version only for a start: const StyleBuilder* styleBuilder() const; |
| src/lib/marble/MarbleWidget.h | ||
| 251 ↗ | (On Diff #5474) | const only for a start here as well const StyleBuilder* styleBuilder() const; |
| src/lib/marble/MarbleWidgetPopupMenu.cpp | ||
| 616 ↗ | (On Diff #5394) | That seems quite a long statement. What about breaking it down like this? bool hasOsmData = false;
QStringList recognizedTags;
recognizedTags << "name" << "amenity" << "cuisine" << "opening_hours";
recognizedTags << "addr:street" << ...
foreach(const QString &tag, recognizedTags) {
if (data.containsTagKey(tag)) {
hasOsmData = true;
break;
}
} |
| src/lib/marble/webpopup/osm.html | ||
| 77 ↗ | (On Diff #5394) | Let's go for a clickable link: <td>Website:</td><td><a href="%website%">%website%</a></td> |