pull platforms/distributions dynamically out of the bugzilla api
ClosedPublic

Authored by sitter on Jul 16 2019, 3:17 PM.

Details

Summary

this ensures that all known platforms are actually in the comobox and
reduces the amount of string duplication.

the new code gets the list of platforms from bugzilla and then either
attempts to select the one which was auto-detected by systeminformation
or recycle the one previously used.

setup is now triggered in the constructor. loading from the api is still
fairly cheap but even so takes longer than the hardcoded list, so
loading this on aboutToShow is fairly unattractive at this point.

the now useless members for combobox state tracking are gone entirely.

BUG: 383530
CHANGELOG: The list of available platforms is now always in sync with the list on bugzilla itself

Test Plan

list gets loaded as expected
list errors as expected when offline

Diff Detail

Repository
R871 DrKonqi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jul 16 2019, 3:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 16 2019, 3:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Jul 16 2019, 3:17 PM
apol accepted this revision.Jul 16 2019, 3:38 PM
This revision is now accepted and ready to land.Jul 16 2019, 3:38 PM
This revision was automatically updated to reflect the committed changes.