Add ability to copy the URL of played media
ClosedPublic

Authored by gshah on Jul 12 2019, 2:51 PM.

Details

Summary

FEATURE: 409743

SUMMARY

STEPS TO REPRODUCE

  1. Click "Play Stream" or "Play File"
  2. Enter stream URL / select file
  3. Once the stream / file starts playing, try to extract the URL of the playing stream / file.

OBSERVED RESULT
If the user forgets the location of the file or URL of the stream, there is no way to get the URL once the media is played.

EXPECTED RESULT
The context menu of the recently played items should provide option to copy the stream URL / file location. Will be handy if the user forgets the original stream URL / file location.

Test Plan

No test plan as this is a minor change.

Diff Detail

Repository
R259 Dragon Player
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gshah requested review of this revision.Jul 12 2019, 2:51 PM
gshah created this revision.
gshah added a reviewer: lukas.Jul 12 2019, 3:00 PM
sitter added inline comments.Jul 15 2019, 1:55 PM
src/app/recentlyPlayedList.cpp
47
124

you can use toUrl() instead of going through the typed-value. A bit shorter and easier on the eyes.

gshah updated this revision to Diff 61796.Jul 15 2019, 3:10 PM

Implemented the review comments.

gshah marked 2 inline comments as done.Jul 15 2019, 3:10 PM
sitter accepted this revision.Jul 16 2019, 11:14 AM

It's a work of perfection. Thanks! :)

This revision is now accepted and ready to land.Jul 16 2019, 11:14 AM
This revision was automatically updated to reflect the committed changes.