Anchors in a layout item is always wrong
AbandonedPublic

Authored by davidedmundson on Jul 21 2016, 12:33 AM.

Details

Reviewers
sebas
Group Reviewers
Plasma
Test Plan

Opened it, looks the same

Diff Detail

Repository
R119 Plasma Desktop
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson retitled this revision from to Anchors in a layout item is always wrong.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 21 2016, 12:33 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added a subscriber: apol.Jul 21 2016, 9:05 AM
apol added inline comments.
desktoppackage/contents/explorer/WidgetExplorer.qml
264

If it needs to be aligned to the right, shouldn't it have a Layout.alignment: Qt.AlignRight?

sebas requested changes to this revision.Jul 25 2016, 12:27 PM
sebas added a reviewer: sebas.
This revision now requires changes to proceed.Jul 25 2016, 12:27 PM

It doesn't need changes, it's already aligned right implicitly.

desktoppackage/contents/explorer/WidgetExplorer.qml
264

It already effectively is.

It's RowLayout {

Item{
    FillWidth:true
}
Button {
}

Button {

}

Button {

  //this one here
}

}

davidedmundson abandoned this revision.Aug 19 2016, 9:30 AM

I merged this a while ago. Closing.