Allow updating default DBus timeout on every interface
ClosedPublic
Actions

Authored by aleksanderm on Jul 11 2019, 11:00 AM.

Details

Reviewers

jgrulich
broulik

Group Reviewers

Frameworks

Commits

R281:a3d262f58d2f: Allow updating default DBus timeout on every interface

Summary

Some methods in the ModemManager API (e.g. network scan) may take
longer to complete than the default DBus timeout configured for the
QDBusAbstractInterface, which is 25s usually.

Allow clients to update this default timeout on every interface.

Diff Detail

Repository

R281 ModemManagerQt

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

aleksanderm created this revision.Jul 11 2019, 11:00 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptJul 11 2019, 11:00 AM

Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

aleksanderm requested review of this revision.Jul 11 2019, 11:00 AM

Harbormaster completed remote builds in B13845: Diff 61580.Jul 11 2019, 11:00 AM

test.cpp1 KBDownload

attaching a tester program to exercise the new API in one of the interfaces.

I think all the methods should be called timeout() and setTimeout(), you are not changing default timeout which will always be 25s if -1 is set as timeout value. Also the getters should be const methods.

Renamed methods and made the getter const.

Harbormaster completed remote builds in B13847: Diff 61582.Jul 11 2019, 11:27 AM

jgrulich accepted this revision.Jul 11 2019, 11:29 AM

This revision is now accepted and ready to land.Jul 11 2019, 11:29 AM

Closed by commit R281:a3d262f58d2f: Allow updating default DBus timeout on every interface (authored by aleksanderm, committed by jgrulich). · Explain WhyJul 11 2019, 11:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/bearer.h (12 lines)
M			src/bearer.cpp (12 lines)
M			src/call.h (12 lines)
M			src/call.cpp (12 lines)
M			src/modem.h (12 lines)
M			src/modem.cpp (12 lines)
M			src/modem3gpp.h (12 lines)
M			src/modem3gpp.cpp (12 lines)
M			src/modem3gppussd.h (12 lines)
M			src/modem3gppussd.cpp (12 lines)
M			src/modemcdma.h (12 lines)
M			src/modemcdma.cpp (12 lines)
M			src/modemlocation.h (12 lines)
M			src/modemlocation.cpp (12 lines)
M			src/modemmessaging.h (12 lines)
M			src/modemmessaging.cpp (12 lines)
M			src/modemoma.h (12 lines)
M			src/modemoma.cpp (12 lines)
M			src/modemsignal.h (12 lines)
M			src/modemsignal.cpp (12 lines)
M			src/modemsimple.h (12 lines)
M			src/modemsimple.cpp (12 lines)
M			src/modemtime.h (12 lines)
M			src/modemtime.cpp (12 lines)
M			src/modemvoice.h (12 lines)
M			src/modemvoice.cpp (12 lines)
M			src/sim.h (12 lines)
M			src/sim.cpp (12 lines)
M			src/sms.h (13 lines)
M			src/sms.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61580	dbf6544		Jul 11 2019, 11:00 AM	★	★
Diff 2	61582	dbf6544	Renamed methods and made the getter const.	Jul 11 2019, 11:27 AM	★	★
Diff 3	61583	dbf6544	R281:a3d262f58d2f339b5d0e9b8939062b8c4a3db209	Jul 11 2019, 11:32 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
abf8d47538e3	929ebd2c0398	dbf6544940dd	Aleksander Morgado	Allow updating default DBus timeout on every interface (Show More…)	Jul 10 2019, 2:55 PM

Allow updating default DBus timeout on every interfaceClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 61583

src/bearer.h

src/bearer.cpp

src/call.h

src/call.cpp

src/modem.h

src/modem.cpp

src/modem3gpp.h

src/modem3gpp.cpp

src/modem3gppussd.h

src/modem3gppussd.cpp

src/modemcdma.h

src/modemcdma.cpp

src/modemlocation.h

src/modemlocation.cpp

src/modemmessaging.h

src/modemmessaging.cpp

src/modemoma.h

src/modemoma.cpp

src/modemsignal.h

src/modemsignal.cpp

src/modemsimple.h

src/modemsimple.cpp

src/modemtime.h

src/modemtime.cpp

src/modemvoice.h

src/modemvoice.cpp

src/sim.h

src/sim.cpp

src/sms.h

src/sms.cpp

Allow updating default DBus timeout on every interface
ClosedPublic
Actions

Revision Contents
Changeset List