Differential D22394

Polish IPv4 settings dialog
ClosedPublic
Actions

Authored by apol on Jul 11 2019, 10:26 AM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma
Commits
R116:8d5b0b7f140c: Polish IPv4 settings dialog
Summary

Set the hostname as the placeholder text, which will be used if the hostname is empty.
Show an specialValueText and a suffix on the timeout field.
Make sure we don't try to save the dialog if the parent window has been deleted.

Test Plan

Used it

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13841
Build 13859: arc lint + arc unit
apol created this revision.Jul 11 2019, 10:26 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 11 2019, 10:26 AM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jul 11 2019, 10:26 AM
jgrulich accepted this revision.Jul 11 2019, 10:37 AM
This revision is now accepted and ready to land.Jul 11 2019, 10:37 AM
Closed by commit R116:8d5b0b7f140c: Polish IPv4 settings dialog (authored by apol). · Explain WhyJul 11 2019, 11:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61575

View Options

libs/editor/settings/ipv4widget.cpp

Loading...