It is only required with X11 and XCB-XKB.
Details
Details
Diff Detail
Diff Detail
- Repository
- R336 KTouch
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for the patch. If you change the dependencies in the CMake files, you also need to update the README so they stay in sync.
| CMakeLists.txt | ||
|---|---|---|
| 40 | Is it possible to reformulate this line like line 41 (without the QUIET, though)? I would prefer to request Qt features in a consistent way. | |
| CMakeLists.txt | ||
|---|---|---|
| 40 | For optional dependencies, it is better to do it this way. Otherwise, if the dependency is disabled or not found, Qt5_FOUND is set to 0, which does not necessarily lead to failure later on (it can, though) but at a minimum leads to conflicting FeatureSummary output (Qt5 not found or sth. along those lines). | |
| CMakeLists.txt | ||
|---|---|---|
| 40 | Okay. | |