Continuation of D22191 and is built on top of it. Instead of having a niche option for a cursor theme with all the underlying infrastructure having to support it, grab the cursor them from a KDE config file and write it to the SDDM config file.
Details
Details
Diff Detail
Diff Detail
- Repository
- R123 SDDM Configuration Panel (KCM)
- Branch
- remove-cursor-theme-option (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14139 Build 14157: arc lint + arc unit
Comment Actions
This should now be completely functional. In order to proceed further, the dependent revision needs to be landed and then this patch rebased on master.
sddmauthhelper.cpp | ||
---|---|---|
54 ↗ | (On Diff #61940) | Task for another day, we don't need to pass this in every time. We can set this at compile time, using the same values from config.h as the KCM would use |
src/advanceconfig.cpp | ||
149 ↗ | (On Diff #61940) | why? |
src/ui/advanceconfig.ui | ||
193 ↗ | (On Diff #61940) | that seems odd? |
sddmauthhelper.cpp | ||
---|---|---|
54 ↗ | (On Diff #61940) | +1 |
src/advanceconfig.cpp | ||
149 ↗ | (On Diff #61940) | I need the identifier to delete the entry in the config file (done in sddmauthhelper.cpp), the value is not important so I just set whatever. Any smarter way of doing this? |
src/ui/advanceconfig.ui | ||
193 ↗ | (On Diff #61940) | Definitely does, QtDesigner can be weird. Going to undo that. |
src/advanceconfig.cpp | ||
---|---|---|
149 ↗ | (On Diff #61940) | args[QStringLiteral("kde_settings.conf/Theme/CursorTheme")] = QVariant(); Then in sddmauthhelper, something like if (fileName == QLatin1String("kde_settings.conf")) { if (iterator.value().isValid()) { sddmConfig->group(groupName).writeEntry(keyName, iterator.value()); } else { sddmConfig->group(groupName).deleteEntry(keyName); } sddmOldConfig->group(groupName).deleteEntry(keyName); } } |