Send options as an Array
*should* be faster as potentially there will be just one allocation
Rename variable: QApplication qa to app.
qa means nothing and the default for Qt apps is to have the
QApplication var named app.
Return directly without creating temporaries
Extract logic from main function
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I do wonder if it wouldn't make sense to make the two helpers into a new class DrKonqiLauncher or some such and then delegate this entire decision to the class. The way this was before the diff is weird, and the way it is after the diff is still weird IMHO. Also the two objects that are allocated in the two methods aren't properly deleted anywhere it seems.
| src/main.cpp | ||
|---|---|---|
| 56 | excess space before ( | |