Differential D22318

Uniform to using Utils::bool2Str().
ClosedPublic
Actions

Authored by barchiesi on Jul 8 2019, 7:52 AM.

Tags

Subscribers

Details

Reviewers

Commits

R477:ed9a2fb0ec3d: Uniform to using Utils::bool2Str().

Summary

Use Utils::bool2Str instead of ternary operator when converting boolean to string for serialization.

Diff Detail

Repository

R477 KGAPI Library

Branch

boolean_cleanup (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13688
Build 13706: arc lint + arc unit

barchiesi created this revision.Jul 8 2019, 7:52 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 8 2019, 7:52 AM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

barchiesi requested review of this revision.Jul 8 2019, 7:52 AM

Harbormaster completed remote builds in B13688: Diff 61309.Jul 8 2019, 7:52 AM

barchiesi edited the summary of this revision. (Show Details)Jul 8 2019, 7:52 AM

Nice!

This revision is now accepted and ready to land.Jul 9 2019, 1:49 PM

Closed by commit R477:ed9a2fb0ec3d: Uniform to using Utils::bool2Str(). (authored by barchiesi). · Explain WhyJul 9 2019, 2:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/contacts/contactsservice.cpp (4 lines)
M			src/core/job.cpp (3 lines)
M			src/drive/changefetchjob.cpp (4 lines)
M			src/drive/childreferencecreatejob.cpp (2 lines)
M			src/drive/drivesfetchjob.cpp (4 lines)
M			src/drive/drivesmodifyjob.cpp (4 lines)
M			src/drive/drivessearchquery.cpp (3 lines)
M			src/drive/fileabstractmodifyjob.cpp (2 lines)
M			src/drive/filefetchjob.cpp (4 lines)
M			src/drive/filesearchquery.cpp (3 lines)
M			src/drive/parentreferencecreatejob.cpp (2 lines)
M			src/drive/permissioncreatejob.cpp (2 lines)
M			src/drive/permissiondeletejob.cpp (3 lines)
M			src/drive/permissionfetchjob.cpp (2 lines)
M			src/drive/permissionmodifyjob.cpp (2 lines)
M			src/drive/teamdrivefetchjob.cpp (4 lines)

Diff 61309

src/contacts/contactsservice.cpp

Loading...

src/core/job.cpp

Loading...

src/drive/changefetchjob.cpp

Loading...

src/drive/childreferencecreatejob.cpp

Loading...

src/drive/drivesfetchjob.cpp

Loading...

src/drive/drivesmodifyjob.cpp

Loading...

src/drive/drivessearchquery.cpp

Loading...

src/drive/fileabstractmodifyjob.cpp

Loading...

src/drive/filefetchjob.cpp

Loading...

src/drive/filesearchquery.cpp

Loading...

src/drive/parentreferencecreatejob.cpp

Loading...

src/drive/permissioncreatejob.cpp

Loading...

src/drive/permissiondeletejob.cpp

Loading...

src/drive/permissionfetchjob.cpp

Loading...

src/drive/permissionmodifyjob.cpp

Loading...

src/drive/teamdrivefetchjob.cpp

Loading...