Differential D22286

[kcmkwin] Add a clear button to the Desktop Effects search field
ClosedPublic
Actions

Authored by filipf on Jul 5 2019, 9:32 AM.

Details

Reviewers
davidedmundson
ngraham
Group Reviewers
KWin
VDG
Commits
R108:f2bbb60419f8: [kcmkwin] Add a clear button to the Desktop Effects search field
Summary

This patch adds a clear button to the Desktop Effects search field by using Kirigami's SearchField.

Test Plan

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Jul 5 2019, 9:32 AM
Restricted Application added a project: KWin. · View Herald TranscriptJul 5 2019, 9:32 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
filipf requested review of this revision.Jul 5 2019, 9:32 AM
filipf edited the test plan for this revision. (Show Details)Jul 5 2019, 9:33 AM
filipf added reviewers: KWin, VDG.
davidedmundson accepted this revision.Jul 5 2019, 9:37 AM
This revision is now accepted and ready to land.Jul 5 2019, 9:37 AM
ngraham requested changes to this revision.Jul 5 2019, 10:15 AM
ngraham added a subscriber: ngraham.

Use the SearchField instead

This revision now requires changes to proceed.Jul 5 2019, 10:15 AM
filipf updated this revision to Diff 61200.Jul 5 2019, 10:19 AM

Use Kirigami.SearchField instead of Kirigami.ActionTextField

filipf edited the summary of this revision. (Show Details)Jul 5 2019, 10:20 AM
ngraham accepted this revision.Jul 5 2019, 2:34 PM
This revision is now accepted and ready to land.Jul 5 2019, 2:34 PM
Closed by commit R108:f2bbb60419f8: [kcmkwin] Add a clear button to the Desktop Effects search field (authored by filipf). · Explain WhyJul 6 2019, 7:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 61244

View Options

kcmkwin/kwineffects/package/contents/ui/main.qml

Loading...