Differential D22278

Remove Compositor created check
ClosedPublic
Actions

Authored by romangg on Jul 4 2019, 6:02 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Maniphest Tasks
T11071: Rework compositing pipeline
Commits
R108:d21f09d4ab2e: Remove Compositor created check
Summary

Cleans up the Compositor code some more. The check is only
used in a single assert statement.

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Branch
rmIsCreated
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13618
Build 13636: arc lint + arc unit
romangg created this revision.Jul 4 2019, 6:02 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 4 2019, 6:02 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Jul 4 2019, 6:02 PM
zzag accepted this revision.Jul 4 2019, 6:12 PM
zzag added a subscriber: zzag.
zzag added inline comments.
thumbnailitem.cpp
44

Perhaps it's still a good idea to verify that the compositor is created by doing Q_ASSERT(Compositor::self()).

This revision is now accepted and ready to land.Jul 4 2019, 6:12 PM
zzag added inline comments.Jul 4 2019, 6:14 PM
thumbnailitem.cpp
44

... though it doesn't matter. If the compositor is not created by this time, we'll crash in either case.

Closed by commit R108:d21f09d4ab2e: Remove Compositor created check (authored by romangg). · Explain WhyJul 4 2019, 6:19 PM
This revision was automatically updated to reflect the committed changes.
romangg marked 2 inline comments as done.

Revision Contents
Changeset List

PathPackages
Mcomposite.h (10 lines)
Mthumbnailitem.cpp (1 line)

Diff 61165

View Options

composite.h

Loading...
View Options

thumbnailitem.cpp

Loading...