get rid of blockSignals
ClosedPublic

Authored by mart on Jul 3 2019, 6:00 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R296:087be3e4f4be: get rid of blockSignals
Summary

Don't call blockSignals, but instead, to avoid an infinite signal chain,
check KCoreConfigSkeleton::configChanged wasn't emitted by ourselves writing on the
config.
Plasma::Applet::configChanged() slot was never invoked when config was written from
QML, which is wrong.

Test Plan

Config still loads, plasma which makes heavy use of this still loads and saves
configs correctly, no infinite signal/slot recursions.
Now if somebody connects to KCoreConfigSkeleton::configChanged from outside of
this class, it wil lreceive correct signals when somebody writes to the config from
QML.

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Jul 3 2019, 6:00 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 3 2019, 6:00 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Jul 3 2019, 6:00 PM
mart added a reviewer: Plasma.Jul 3 2019, 6:00 PM
apol accepted this revision.Jul 3 2019, 6:06 PM
apol added a subscriber: apol.

LGTM

This revision is now accepted and ready to land.Jul 3 2019, 6:06 PM
This revision was automatically updated to reflect the committed changes.