[kcmkwin/compositing] Remove combobox to select between GLX and EGL
ClosedPublic

Authored by graesslin on Jul 19 2016, 3:10 PM.

Details

Summary

The selection of whether GLX or EGL should be used doesn't work in
practice due to the following reasons:

  • Intel/EGL/X11 results in rendering errors
  • NVIDIA still doesn't support EGL
  • OpenGLES forces to EGL (combobox only one entry)
  • Wayland forces to EGL (combobox only one entry)

Offering the selection only offers the user a way to destroy the
system. We get too many bug reports about rendering errors and we
get too many complaints about this not working properly on social
media. E.g.: "The Meh: EGL mode causes bugs in the launcher"

The configuration interface showed a warning when selecting it, but
apparently users ignore warnings like "might be broken". If that's the
case let's better remove the option.

If users really want this they can still enable it manually through
editing the config file or through the env variable.

Change intended for Plasma/5.7 branch - I'm sick of users complaining
about it!

Test Plan

Opened KCM, verified Combobox is gone

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 5314.Jul 19 2016, 3:10 PM
graesslin retitled this revision from to [kcmkwin/compositing] Remove combobox to select between GLX and EGL.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma, VDG.
Restricted Application added a project: KWin. · View Herald TranscriptJul 19 2016, 3:10 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
sebas accepted this revision.Jul 20 2016, 11:26 AM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.

Makes sense. Hope users won't complain that we're making it harder for them to screw up...

This revision is now accepted and ready to land.Jul 20 2016, 11:26 AM

Just a personal comment (don't take it as opposition to the patch): On my machine with an ATI chip using the radeon mesa driver, EGL actually causes less problems than GLX. I don't know why, but that's my consistent experience.
If the group of people like me is indeed small enough, editing the config manually to get EGL is fine, of course.

If the group of people like me is indeed small enough, editing the config manually to get EGL is fine, of course.

yes I'm quite sure that you're in the odd group of those where it actually works and renders better results. (Though means we should look at your glx setup and why it renders worse results).

This revision was automatically updated to reflect the committed changes.